Bumped upload-artifact action from v3 to v4 #1827
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Eric Reinecke <[email protected]>
reinecke
force-pushed
the
bump-upload-artifact-to-v4
branch
from
0d1ab0b to
a58efc3
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1827 +/- ##
==========================================
+ Coverage 84.11% 84.75% +0.63%
==========================================
Files 198 176 -22
Lines 22241 12711 -9530
Branches 4687 1181 -3506
==========================================
- Hits 18709 10773 -7936
+ Misses 2610 1760 -850
+ Partials 922 178 -744
Flags with carried forward coverage won't be shown. Click here to find out more. see 129 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
te upload artifact Signed-off-by: Eric Reinecke <[email protected]>
… deprecated implicit merge behavior available in v3 upload artifact. Updated pypi publish to match new artifact name pattern Signed-off-by: Eric Reinecke <[email protected]>
reinecke
force-pushed
the
bump-upload-artifact-to-v4
branch
from
65d2411 to
c57e115
Compare
Signed-off-by: Eric Reinecke <[email protected]>
…rtifact names Signed-off-by: Eric Reinecke <[email protected]>
darbyjohnston
added a commit
to darbyjohnston/OpenTimelineIO
that referenced
this pull request
Jan 30, 2025
Signed-off-by: Darby Johnston <[email protected]>
darbyjohnston
added a commit
that referenced
this pull request
Feb 5, 2025
* Eric's fixe from PR #1827 Signed-off-by: Darby Johnston <[email protected]> * Update dawidd6/action-download-artifact to v8 Signed-off-by: Darby Johnston <[email protected]> * Try updating pypa/cibuildwheel Signed-off-by: Darby Johnston <[email protected]> * Update setup-python Signed-off-by: Darby Johnston <[email protected]> * Try using native ARM runner Signed-off-by: Darby Johnston <[email protected]> * Use ubuntu-latest and ubuntu-24.04-arm Signed-off-by: Darby Johnston <[email protected]> * Set MACOSX_DEPLOYMENT_TARGET Signed-off-by: Darby Johnston <[email protected]> * Use default images Signed-off-by: Darby Johnston <[email protected]> * Try setting CIBW_ARCHS_LINUX to auto Signed-off-by: Darby Johnston <[email protected]> * Try setting CIBW_ARCHS_LINUX explicitly Signed-off-by: Darby Johnston <[email protected]> * Add back ticks Signed-off-by: Darby Johnston <[email protected]> * Set images explicitly Signed-off-by: Darby Johnston <[email protected]> * Try removing CIBW_ARCHS_LINUX Signed-off-by: Darby Johnston <[email protected]> * Try setting CIBW_ARCHS_LINUX to native Signed-off-by: Darby Johnston <[email protected]> * Remove old code Signed-off-by: Darby Johnston <[email protected]> --------- Signed-off-by: Darby Johnston <[email protected]>
|
Superseded by #1828. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #1740
Bump upload-artifact github action to v4 in line with deprecation.
The V4 update no longer supports implicit merge of matrixed build products into a single uploaded artifact (in v3 all wheel platform/python version variants were implicitly merged into a
wheelsartifact). This update makes a separate artifact for each matrix variant ant then merges them on download when creating a release to push to pypi.